Homestyx hydra
Diffusion hydra b0044bad621b

Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global…

Description

Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15348

Test Plan:
Applied this change (on top of D25157) and creation form at /herald/edit/?content_type=HeraldPreCommitRefAdapter&rule_type=personal rendered in web browser.
Same applies for other types of personal and global Herald rules.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15348

Differential Revision: https://we.phorge.it/D25190

Details

Provenance
Andre KlapperAuthored on May 5 2023, 6:52 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:8eaa7c1ccf3d: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a config page
Branches
Unknown
Tags
Unknown

Event Timeline