Homestyx hydra
Diffusion hydra 8eaa7c1ccf3d

Fix PHP 8.1 "strlen(null)" exception which blocks rendering a config page

Description

Fix PHP 8.1 "strlen(null)" exception which blocks rendering a config page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15336

Test Plan: Applied this change and /config/edit/load-libraries/ correctly rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15336

Differential Revision: https://we.phorge.it/D25181

Details

Provenance
Valerio BozzolanAuthored on May 4 2023, 4:48 AM
Andre KlapperCommitted on May 4 2023, 4:48 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:953726d71bfa: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an…
Branches
Unknown
Tags
Unknown

Event Timeline