Homestyx hydra
Diffusion hydra 43539b220ce2

Remove trivial cases of unreachable code

Description

Remove trivial cases of unreachable code

Summary:
Static code analysis can detect Unreachable statement - code above always terminates.
The vast majority of occurrences in the Phorge codebase are due to an unreachable break within a case after a return or after an all-covering if/else.
All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases.

Test Plan: Examine the code; run static code analysis.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25802

Details

Provenance
Andre KlapperAuthored on Aug 24 2024, 4:46 AM
sirocylPushed on Wed, Oct 16, 5:49 AM
Parents
R1:8c3a62d6afd0: Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
Branches
Unknown
Tags
Unknown

Event Timeline