Homestyx hydra
Diffusion hydra 8c3a62d6afd0

Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text

Description

Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Refs T15936

Test Plan: Read the code; compare to D25186.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15936

Differential Revision: https://we.phorge.it/D25817

Details

Provenance
Andre KlapperAuthored on Sep 4 2024, 4:12 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:24ebac8ad734: Remove unused shouldUse* functions from PhabricatorRepository
Branches
Unknown
Tags
Unknown

Event Timeline