When cancelling an inline comment edit, exit the edit state after the response…
f45519c0604b
Actions

Description

When cancelling an inline comment edit, exit the edit state after the response arrives

Summary: Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.

Test Plan:

Clicked a line number.
Typed some text.
Clicked "Cancel".
Before patch: paths panel flashes "1".
After patch: paths panel stays stable.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21253

Details

Provenance

epriestley	Authored on May 14 2020, 2:17 PM
sirocyl	Pushed on Oct 16 2024, 5:49 AM

Parents

R1:cfb5de6fa77f: Distinguish more carefully between "null" inline offsets and "0" inline offsets

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

R1:f45519c0604b

View Options

resources/celerity/map.php