Homestyx hydra
Diffusion hydra dc6c1bf4351e

Fail quietly when failing to write access log

Description

Fail quietly when failing to write access log

Summary: See D5874. PhutilDeferredLog's exception on write()/__destruct() is not especially important and can come at an awkward time. Instead of throwing, just emit an error message to the log.

Test Plan: Faked failed writes and saw an error message in the log instead of many terrible things everywhere.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3144

Differential Revision: https://secure.phabricator.com/D5875

Details

Provenance
epriestleyAuthored on May 9 2013, 7:08 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:83109ff8afcd: Update Celerity
Branches
Unknown
Tags
Unknown

Event Timeline