Homestyx hydra
Diffusion hydra d58eddcf0ad4

When predicting project membership during edits, predict milestones will have…

Description

When predicting project membership during edits, predict milestones will have parent membership

Summary:
Depends on D20919. Ref T13462. When editing milestones, we currently predict they will have no members for policy evaluation purposes. This isn't the right rule.

Instead, predict that their membership will be the same as the parent project's membership, and pass this hint to the policy layer.

See T13462 for additional context and discussion.

Test Plan:

  • Set project A's edit policy to "Project Members".
  • Joined project A.
  • Tried to create a milestone of project A.
    • Before: policy exception that the edit policy excludes me.
    • After: clean milestone creation.
  • As a non-member, tried to create a milestone. Received appropriate policy error.

Maniphest Tasks: T13462

Differential Revision: https://secure.phabricator.com/D20920

Details

Provenance
epriestleyAuthored on Nov 19 2019, 1:49 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:959504a4881c: When predicting object policies for project milestones, adjust objects so they…
Branches
Unknown
Tags
Unknown

Event Timeline