Homestyx hydra
Diffusion hydra d1225e782b0e

Don't try to load user profile images in PhabricatorPeopleQuery if no users…

Description

Don't try to load user profile images in PhabricatorPeopleQuery if no users have any

Summary:
Fixes T3810. In PhabricatorPeopleQuery, we issue an unnecessary query like this:

SELECT f.* FROM file f WHERE (f.phid IN ('')) ORDER BY f.id DESC

...if we're loading a user without a profile picture. Filter the file PHIDs before loading them to prevent this.

This doesn't change anything, but saves us a spurious/silly query.

Also makes PhabricatorPeopleProfileController use needProfileImage(), moving us closer to getting rid of loadProfileImageURI() eventually.

Test Plan: Looked at profiles of users with and without profile pictures. Checked query log in DarkConsole.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Maniphest Tasks: T3810

Differential Revision: https://secure.phabricator.com/D6913

Details

Provenance
epriestleyAuthored on Sep 8 2013, 12:43 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:194245ed622d: Clean up some more Diviner stuff
Branches
Unknown
Tags
Unknown

Event Timeline