Homestyx hydra
Diffusion hydra c86364c2aa6d

Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after…

Description

Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15374

Test Plan: Applied these two changes, performed the user creation steps again, and afterwards the user page at /p/user5/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15374

Differential Revision: https://we.phorge.it/D25208

Details

Provenance
Andre KlapperAuthored on May 10 2023, 4:27 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:ac4c95169973: Fix PHP 8.1 "strlen(null)" exception which blocks dragging a task to a…
Branches
Unknown
Tags
Unknown

Event Timeline