Homestyx hydra
Diffusion hydra c52e10d1ecf0

Respect external unmentionable PHIDs in Differential revision editor

Description

Respect external unmentionable PHIDs in Differential revision editor

Summary:
See PHI574. Ref T13120. When you Ref Txx or Fixes Txxx, we mark it "unmentionable" to prevent the task from generating both a reference and a mention.

If you add a reference to an object (like a commit hash) to a custom remarkup field, there's currently no real way to prevent it from generating a mention, except that you can explicitly mark the PHID as unmentionable on the Editor.

This isn't exactly a first-class feature, but we technically do it in PhabricatorRepositoryCommitMessageParserWorker, and it probably doesn't hurt or interfere with anything to support it slightly better.

In Differential, respect any existing value and append new values to it rather than overwriting the value.

Test Plan: Edited a revision summary to include Ref Txxx, saw only a reference (not a mention) generate.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13120

Differential Revision: https://secure.phabricator.com/D19361

Details

Provenance
epriestleyAuthored on Apr 12 2018, 5:58 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:70056a9072d3: When creating a file by downloading a URI, truncate the length of the default…
Branches
Unknown
Tags
Unknown

Event Timeline