Homestyx hydra
Diffusion hydra c03297ab5a0a

Fix interaction between undo and inline comment placement

Description

Fix interaction between undo and inline comment placement

Summary:
Fixes T7658. Currently, we remove the "undo" before placing the comment, but that causes us to lose track of which row we should be examining.

Instead, place the comment first, then remove the "undo".

Test Plan: This stuff is hard to test comprehensively, but the original report reproduced easily and is now fixed. I wasn't able to break anything by adding/editing/deleting comments.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7658

Differential Revision: https://secure.phabricator.com/D12157

Details

Provenance
epriestleyAuthored on Mar 25 2015, 10:14 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:4f8147dbb8c0: Improve protection against SSRF attacks
Branches
Unknown
Tags
Unknown

Event Timeline