Homestyx hydra
Diffusion hydra c0191a039293

Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune

Description

Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/phortune/provider/PhortunePaymentProvider.php:99]

Closes T15725

Test Plan: See steps in T15725

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15725

Differential Revision: https://we.phorge.it/D25528

Details

Provenance
Andre KlapperAuthored on Jan 26 2024, 1:12 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:7a86040f8a46: Avoid exception setting project profile image when GD not installed
Branches
Unknown
Tags
Unknown

Event Timeline