Homestyx hydra
Diffusion hydra be21dd3b52b8

Fix some "URI->alter(X, null)" callsites

Description

Fix some "URI->alter(X, null)" callsites

Summary:
Ref T13250. This internally calls replaceQueryParam(X, null) now, which fatals if the second parameter is null. I hit these legitimately, but I'll look for more callsites and follow up by either allowing this, removing alter(), fixing the callsites, or some combination.

(I'm not much of a fan of alter().)

Test Plan: Browsing a paginated list no longer complains about URI construction.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13250

Differential Revision: https://secure.phabricator.com/D20162

Details

Provenance
epriestleyAuthored on Feb 13 2019, 12:13 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:5892c7898603: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Branches
Unknown
Tags
Unknown

Event Timeline