Homestyx hydra
Diffusion hydra b32b84b64515

Fix exception for anonymous viewers on dashboard query panels with user…

Description

Fix exception for anonymous viewers on dashboard query panels with user-specific data

Summary:
When a viewer is not logged in and opens a public dashboard which embeds a query panel whose data requires a Current Viewer context (e.g. assigned or authored tasks, or joined projects), do not throw an exception but show an explanatory placeholder sentence (similar to already existing 'No tasks found.' or 'No documents found.' strings).

EXCEPTION: (Exception) Query "assigned" is unknown to application search engine "ManiphestTaskSearchEngine"! at [<phorge>/src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php:80]
EXCEPTION: (Exception) Query "joined" is unknown to application search engine "PhabricatorProjectSearchEngine"! at [<phorge>/src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php:80]

Closes T15792

Test Plan: While logged in, set up a dashboard query panel with "Search For: Maniphest Tasks" and "Query: Assigned" and add it to a public Dashboard. While logged out, access the Dashboard and see explanation message instead of Exception: Query "assigned" is unknown to application search engine "ManiphestTaskSearchEngine"! on the dashboard.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15792

Differential Revision: https://we.phorge.it/D25598

Details

Provenance
Andre KlapperAuthored on Apr 19 2024, 7:51 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:4d12d014fd9d: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes
Branches
Unknown
Tags
Unknown

Event Timeline