Homestyx hydra
Diffusion hydra b1e2d3cd2950

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior

Description

Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior

Summary:
Depends on D20371. Ref T13272. Dashboard panels use CustomField to specify editable panel behavior. This is an older approach which was largely or entirely obsoleted by EditEngine.

Throw away all the CustomField edit stuff. Convert the "text" panel to EditEngine to prove this at least mostly works.

This breaks "query" panels and "tab" panels (they'll still work fine, but they can't be meaningfully edited). I'll restore those in a future change.

Test Plan: Created and edited a "text" panel.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20372

Details

Provenance
epriestleyAuthored on Apr 2 2019, 2:15 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:68d969094ffb: Mostly replace the old panel "Edit" controller with the new "Editpro" controller
Branches
Unknown
Tags
Unknown

Event Timeline