Homestyx hydra
Diffusion hydra b021da71a52d

When users click headers to select diff UI elements, don't eat the events

Description

When users click headers to select diff UI elements, don't eat the events

Summary: Ref T13513. Currently, clicking inline or changeset headers eats the click events. This doesn't serve any clear purpose, and means these clicks do not clear text selections from the document, which is unusual.

Test Plan:

  • Selected some text in a diff.
  • Clicked a changeset header to select it.
  • Before patch: text selection and context menu were retained.
  • After patch: text selection was cleared and context menu was dismissed.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21255

Details

Provenance
epriestleyAuthored on May 14 2020, 2:43 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:42f1a95a1255: Fix a flash of document selection when "oncopy" and "inline on range" behaviors…
Branches
Unknown
Tags
Unknown

Event Timeline