Homestyx hydra
Diffusion hydra a83ba95445e1

Only display "Calendar" entry in user profile page menu on mobile when Calendar…

Description

Only display "Calendar" entry in user profile page menu on mobile when Calendar application is installed

Summary:
https://we.phorge.it/source/phorge/browse/master/src/view/page/PhabricatorStandardPageView.php$908 tries to "find some navigational menu items to create a mobile navigation menu from" but does not succeed too much it seems:
On a user profile page, that very code calls buildApplicationMenu() in PhabricatorPeopleController which calls buildSideNavView() in the same class.
This code unconditionally displays a "Calendar" menu item, no matter if the Calendar application is installed or not. Thus check first to avoid offering a link ending up in a 404.

For the time being this change renders the menu empty (apart from a link to the page we are already on) but that's more acceptable than all those tears shed by devastated users after clicking the Calendar menu item while being excited and full of anticipation, just to end up on a 404 page instead.

Related: T15224

Test Plan:

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25683

Details

Provenance
Andre KlapperAuthored on Jun 7 2024, 12:43 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:d2bca2f32da0: Fix call to non-existing getTransactionCommentForSave() in…
Branches
Unknown
Tags
Unknown

Event Timeline