Homestyx hydra
Diffusion hydra a5d8b2d5cfd6

Fix a PHP 8.1 deprecated use of preg_match with a NULL argument

Description

Fix a PHP 8.1 deprecated use of preg_match with a NULL argument

Summary:
These calls are preventing users to browse subversion/mercurial repositories in PHP 8.1+.
Indeed, a similar bug affecting git repositories was already addressed in another commit
(rP6b8ec50148909938850b5acfd11725ae23a8e31b). This commit harmonize both DiffusionSvnRequest
and DiffusionMercurialRequest with DiffusionGitRequest

Fix T15607

Test Plan:

  • Sign in
  • Open a diffusion SVN/Mercurial repository
  • You should not get a RuntimeException concerning this preg_match call

Reviewers: O1 Blessed Committers, Sten, valerio.bozzolan

Reviewed By: O1 Blessed Committers, Sten, valerio.bozzolan

Subscribers: Sten, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15607

Differential Revision: https://we.phorge.it/D25397

Details

Provenance
bobAuthored on Aug 17 2023, 4:16 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:9fa9aa30b940: Fix PHP 8.1 "strlen(null)" exception on "Link External Account" page at login
Branches
Unknown
Tags
Unknown

Event Timeline