Homestyx hydra
Diffusion hydra a4cc1373d3a2

Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose…

Description

Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners

Summary: Depends on D19190. Fixes T12590. Ref T13099. Replaces the barely-usable, gigantic, poorly ordered "<select />" control with a tokenizer. Attempts to fix various minor issues.

Test Plan:

  • Edited paths: include/exclude paths, from different repositories, different actual paths.
  • Used "Add New Path" to add rows, got repository selector prepopulated with last value.
  • Used "remove".
  • Used validation typeahead, got reasonable behaviors?

The error behavior if you delete the repository for a path is a little sketchy still, but roughly okay.

Maniphest Tasks: T13099, T12590

Differential Revision: https://secure.phabricator.com/D19191

Details

Provenance
epriestleyAuthored on Mar 7 2018, 8:29 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:b41a0e6ddda3: Fix broken suggestion/validation for Owners paths in repositories with short…
Branches
Unknown
Tags
Unknown

Event Timeline