Stop using forms to download files in file embed and lightbox elements
a2fdf14275f9
Actions

Description

Stop using forms to download files in file embed and lightbox elements

Summary: Depends on D19156. Ref T13094. This replaces the remaining forms in the file embed view and lightbox with normal download links.

Test Plan: Clicked "Download" and lightbox -> download for embedded files.

Maniphest Tasks: T13094

Differential Revision: https://secure.phabricator.com/D19157

Details

Provenance

epriestley	Authored on Feb 28 2018, 8:04 PM
sirocyl	Pushed on Oct 16 2024, 5:49 AM

Parents

R1:ab579f251110: Never generate file download forms which point to the CDN domain, tighten "form…

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (4)

Path

Size

resources/

celerity/

map.php

src/

view/

layout/

PhabricatorFileLinkView.php

page/

PhabricatorStandardPageView.php

webroot/

rsrc/

js/

core/

behavior-lightbox-attachments.js

R1:a2fdf14275f9

View Options

resources/celerity/map.php

View Options

src/view/layout/PhabricatorFileLinkView.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Stop using forms to download files in file embed and lightbox elementsa2fdf14275f9Actions

Description

Details

Event Timeline

Changes (4)

R1:a2fdf14275f9

resources/celerity/map.php

src/view/layout/PhabricatorFileLinkView.php

src/view/page/PhabricatorStandardPageView.php

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Stop using forms to download files in file embed and lightbox elements
a2fdf14275f9
Actions