Homestyx hydra
Diffusion hydra a2b2c391a1f1

Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and…

Description

Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently

Summary:
Ref T13444. You can currently explicitly unassign an identity (useful if the matching algorithm is misfiring). However, this populates the "currentEffectiveUserPHID" with the "unassigned()" token, which mostly makes things more difficult.

When an identity is explicitly unassigned, convert that into an explicit null in the effective user PHID.

Then, realign "assigned" / "effective" language a bit. Previously, withAssigneePHIDs(...) actualy queried effective users, which was misleading. Finally, bulk up the list view a little bit to make testing slightly easier.

Test Plan:

  • Unassigned an identity, ran migration, saw currentEffectiveUserPHID become NULL for the identity.
  • Unassigned a fresh identity, saw NULL.
  • Queried for various identities under the modified constraints.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13444

Differential Revision: https://secure.phabricator.com/D20908

Details

Provenance
epriestleyAuthored on Nov 13 2019, 10:24 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:df0f5c6cee03: Make repository identity email address association case-insensitive
Branches
Unknown
Tags
Unknown

Event Timeline