Homestyx hydra
Diffusion hydra a1a8083b935f

Transactions - fix pagination bug

Description

Transactions - fix pagination bug

Summary: Fixes T6694. Ref T4712. Turns out the logic here was slightly incorrect; we don't want to use the id of the last thing we hid but rather the first thing we show. I had garbage test data ("asdsadsadsa", etc) I guess so I didn't notice this.

Test Plan: made a new task where user a and user b alternated 3 comments each, cooperatively numbering them from 1 - 20. as both users, showed older transactions. pre-patch the issue described in T6694 occurred and post patch I saw the entire counting sequence.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4712, T6694

Differential Revision: https://secure.phabricator.com/D10933

Details

Provenance
Bob TrahanAuthored on Dec 4 2014, 8:21 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:2856c6093240: Transactions - kill the old "show all" code pathways
Branches
Unknown
Tags
Unknown

Event Timeline