Homestyx hydra
Diffusion hydra a110aa471e98

Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative…

Description

Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()"

Summary:
PHP 8.1 requires classes which implement Iterator to have all Iterator methods declared with appropriate return types or annotated with #[\ReturnTypeWillChange]. In my (limited) understanding we cannot declare return types while remaining backward-compatible, thus annotate.

Closes T15835

Test Plan: Run PHPStan static code analyzer, see no warnings anymore.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15835

Differential Revision: https://we.phorge.it/D25711

Details

Provenance
Andre KlapperAuthored on Jul 2 2024, 9:03 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:721d5ed64b70: fix PHP8 array_slice($results, null) which cause diffusion pattern search broken
Branches
Unknown
Tags
Unknown

Event Timeline