Homestyx hydra
Diffusion hydra 9e6507d37aef

Fix exception handling in ConpherenceViewController::handleRequest()

Description

Fix exception handling in ConpherenceViewController::handleRequest()

Summary:
It is only possible throw an Exception class. Aphront400Response is not an Exception class but a Phobject.
Thus return it, like the Aphront404Responses within the same method.

Test Plan:
Check parent classes; run static code analysis. Hack the code to force that return,
and successfully obtain an HTTP 400 status code page.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25780

Details

Provenance
Andre KlapperAuthored on Aug 15 2024, 9:57 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:b4bc480817cd: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider
Branches
Unknown
Tags
Unknown

Event Timeline