Diffusion hydra 993d94211722

Gently move some listeners into DiffChangesetList
993d94211722
Actions

Description

Gently move some listeners into DiffChangesetList

Summary: Ref T12616. Put these listeners in DiffChangesetList so the wake/sleep properly for Quicksand.

Test Plan:

Added some logging.
With quicksand, moved between diffs.
Saw "load" and "show more" fire exactly once on each page, with the correct changeset list listener.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616

Differential Revision: https://secure.phabricator.com/D17841

Details

Provenance

epriestley	Authored on May 8 2017, 12:17 PM
sirocyl	Pushed on Oct 16 2024, 5:49 AM

Parents

R1:404fe482d914: Add a Quicksand-aware page-level container to diffs

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (3)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

differential/

behavior-populate.js

R1:993d94211722

View Options

resources/celerity/map.php

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Gently move some listeners into DiffChangesetList993d94211722Actions

Description

Details

Event Timeline

Changes (3)

R1:993d94211722

resources/celerity/map.php

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/differential/behavior-populate.js

Gently move some listeners into DiffChangesetList
993d94211722
Actions