Homestyx hydra
Diffusion hydra 98615c354004

Phriction Action View won't render weird actions when document does not exist

Description

Phriction Action View won't render weird actions when document does not exist

Summary:
The actions wouldn't behave as I want. Disabled them and display "Create Document" instead, since the others make no sense on a non-existing page.

The linking was error-prone btw. /phriction/edit// (how it and others would be linked) wouldn't route to anything, and even if, would result in an error anyway since non-existing docs can't be deleted nor have their history shown.

Test Plan:
verified buttons disappeard when document was not created.

verified at least history button would appear when document existed, but was deleted (should work for move, too)

Reviewers: epriestley, chad, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2384

Differential Revision: https://secure.phabricator.com/D5203

Details

Provenance
Anh Nhan NguyenAuthored on Mar 4 2013, 10:21 AM
epriestleyCommitted on Mar 4 2013, 10:21 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:92c4dfdfb19c: Fix an extra %s in BlogFeedController
Branches
Unknown
Tags
Unknown

Event Timeline