Homestyx hydra
Diffusion hydra 9639ec0dfabd

Slightly simplify logic for determining if an inline comment has an effect

Description

Slightly simplify logic for determining if an inline comment has an effect

Summary: Minor cleanup, this logic can be simpler. Instead of special-casing inlines as having an effect if the have a comment, just consider any transaction with a comment to have an effect. I'm fairly certain this is always true.

Test Plan: Made inlines, tried to submit empty comments. Behavior unchanged.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18468

Details

Provenance
epriestleyAuthored on Aug 24 2017, 6:15 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:6c9026c33a45: Allow ModularTransactions to opt in to providing data to Conduit
Branches
Unknown
Tags
Unknown

Event Timeline