Homestyx hydra
Diffusion hydra 8f669ea08289

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page

Description

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as
a general replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Use phutil_nonempty_scalar() instead in PhabricatorSearchDateField.php as
input could only be integer instead of string.

Closes T15297

Test Plan: Applied these four changes (on top of D25144, D25145, D25146) and /people/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15297

Differential Revision: https://we.phorge.it/D25147

Details

Provenance
Andre KlapperAuthored on May 1 2023, 4:31 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:aea1d4737954: Fix PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions which block…
Branches
Unknown
Tags
Unknown

Event Timeline