Homestyx hydra
Diffusion hydra 8f361810737c

Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block

Description

Fix PHP 8.1 "strlen(null)" exception in Diviner when PHPDoc has no @task block

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/diviner/controller/DivinerAtomController.php:440]

Closes T15853

Test Plan: Run ./bin/diviner generate and visit a Diviner page about a class which has no PHPDoc @task block, for example access http://phorge.localhost/diviner/find/?name=PhutilSafeHTML&type=class&jump=1

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15853

Differential Revision: https://we.phorge.it/D25689

Details

Provenance
Andre KlapperAuthored on Jun 10 2024, 7:17 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:214988fafd75: T15774: Celerity: javascript minification issue with template literals…
Branches
Unknown
Tags
Unknown

Event Timeline