Homestyx hydra
Diffusion hydra 8988667dccee

Make Oauth-registration flows a bit more resilient to failures from the…
8988667dccee
Actions

Description

Make Oauth-registration flows a bit more resilient to failures from the providers

Summary: basically by validating we have good user data when we set the user data.

Test Plan: simulated a failure from a phabricator on phabricator oauth scenario. viewed ui that correctly told me there was an error with the provider and to try again.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T1077

Differential Revision: https://secure.phabricator.com/D2337

Details

Provenance
Bob TrahanAuthored on May 1 2012, 5:51 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:458563c68a27: Phame - use post title for the actual web page title
Branches
Unknown
Tags
Unknown

Event Timeline

Changes (14)

PathSize
src/
applications/
auth/
controller/
oauth/
oauth/
provider/
base/
facebook/
github/
google/
phabricator/
auth/
oauth/
provider/
exception/
chatlog/
constants/
base/
PhabricatorOAuthProviderException.php
PhabricatorChatLogConstants.php
people/
controller/
settings/
panels/
oauth/
applications/
auth/
oauth/
provider/
exception/
aphront/
exception/
base/

R1:8988667dccee

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/controller/oauth/PhabricatorOAuthLoginController.php

Loading...
View Options

src/applications/auth/oauth/provider/base/PhabricatorOAuthProvider.php

Loading...
View Options

src/applications/auth/oauth/provider/base/__init__.php

Loading...
View Options

src/applications/auth/oauth/provider/exception/PhabricatorOAuthProviderException.php

Loading...
View Options

src/applications/auth/oauth/provider/exception/__init__.php

Loading...
View Options

src/applications/auth/oauth/provider/facebook/PhabricatorOAuthProviderFacebook.php

Loading...
View Options

src/applications/auth/oauth/provider/github/PhabricatorOAuthProviderGitHub.php

Loading...
View Options

src/applications/auth/oauth/provider/google/PhabricatorOAuthProviderGoogle.php

Loading...
View Options

src/applications/auth/oauth/provider/google/__init__.php

Loading...
View Options

src/applications/auth/oauth/provider/phabricator/PhabricatorOAuthProviderPhabricator.php

Loading...
View Options

src/applications/auth/oauth/provider/phabricator/__init__.php

Loading...
View Options

src/applications/people/controller/settings/panels/oauth/PhabricatorUserOAuthSettingsPanelController.php

Loading...
styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)