Homestyx hydra
Diffusion hydra 7fe622e5d366

Auto-subscription: little less verbose

Description

Auto-subscription: little less verbose

Summary:
When the user "Mrs. Kitten" adds or remove "Mrs. Kitten" as Subscriber,
usually these messages were generated:

Mrs. Kitten added a subscriber: Mrs. Kitten.
Mrs. Kitten removed a subscriber: Mrs. Kitten.

This was a bit like the Spiderman meme self-pointing Spiderman.

After this change, these beautiful messages are generated instead:

Mrs. Kitten subscribed.
Mrs. Kitten unsubscribed.
BeforeAfter
{F286215}{F286216}

Closes T15347

Test Plan:

  • subscribe on something
  • unsubscribe from something
  • all other cases remain as-is

Reviewers: O1 Blessed Committers, bfs, speck

Reviewed By: O1 Blessed Committers, bfs, speck

Subscribers: bfs, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15347

Differential Revision: https://we.phorge.it/D25191

Details

Provenance
Valerio BozzolanAuthored on Jun 15 2023, 5:49 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:1c098c273d06: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami
Branches
Unknown
Tags
Unknown

Event Timeline