Homestyx hydra
Diffusion hydra 7c58ea140374

Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in…

Description

Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=df6c315ace5f), phorge(head=master, ref.master=7cffe557ac24)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php:28]

Closes T15614

Test Plan: Create a Phriction document without slug via Conduit. Get an EXCEPTION: (Exception) No such document. instead of a strlen() exception.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15614

Differential Revision: https://we.phorge.it/D25406

Details

Provenance
Andre KlapperAuthored on Aug 17 2023, 11:42 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:d84dbf8e27ba: Fix PHP 8.1 "strlen(null)" exception creating a Paste without content in…
Branches
Unknown
Tags
Unknown

Event Timeline