Homestyx hydra
Diffusion hydra 7b8ac020b521

Change "Revision Close" story to use commit identities only with no fallback to…

Description

Change "Revision Close" story to use commit identities only with no fallback to commit data

Summary:
See PHI1213. If we don't have identities for "revision X closed by commit Y" stories, just do the plain non-attribution rendering rather than trying to fall back. Falling back won't work since we don't load the data, which should be OK now since identities seem like they're in generally good shape.

(We could probably just throw out the fallback behavior instead, but we can always clean things up later.)

Test Plan: Forced no commit identity on a revision, loaded it, saw reasonable story rendering.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20460

Details

Provenance
epriestleyAuthored on Apr 22 2019, 3:42 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:b0b8926c7564: Fix "before/after" cursor paging for API call "feed.query"
Branches
Unknown
Tags
Unknown

Event Timeline