Homestyx hydra
Diffusion hydra 7909f6a91937

Fix PHP 8.1 "strlen(null)" exception on LDAP login without password

Description

Fix PHP 8.1 "strlen(null)" exception on LDAP login without password

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Note: This patch also corrects two further strlen() occurrences with the same pattern.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorLDAPAuthProvider.php:145]

Closes T15893

Test Plan: Create an LDAP user without setting their password; try to log into Phabricator with that user via the LDAP auth provider.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15893

Differential Revision: https://we.phorge.it/D25748

Details

Provenance
Andre KlapperAuthored on Jul 26 2024, 10:45 AM
sirocylPushed on Wed, Oct 16, 5:49 AM
Parents
R1:903015312a0b: Remove unused parameter from PhabricatorDaemonController::buildSideNavView()…
Branches
Unknown
Tags
Unknown

Event Timeline