Homestyx hydra
Diffusion hydra 788aa453a2c0

Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the…

Description

Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the Applications page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15294

Test Plan: Applied these three changes and /applications/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15294

Differential Revision: https://we.phorge.it/D25144

Details

Provenance
Andre KlapperAuthored on May 1 2023, 9:34 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:e3ad37f79259: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public…
Branches
Unknown
Tags
Unknown

Event Timeline