Log Herald rules having disabled Herald rules as condition via phlog()
Summary:
Do not silently fail when a Herald rule refers in its conditions to a disabled rule.
Allow Phorge administrators to get aware by creating an entry in the error log via phlog() instead of crossing fingers that someone may from time to time get the idea to open and read Herald transcripts.
This is similar to T15885 / D25735.
Refs T15869
Test Plan:
- Phorge at 0873b36569bfcf502a092870d7d5f4d088ed9003
- Set up a Herald rule and disable it
- Set up a second Herald rule with several conditions, the first condition being "Another Herald rule matches" on the disabled first Herald rule
- Go to http://phorge.localhost/herald/test/ to apply the Herald rule on a corresponding object
- See an exception in the resulting transcript at http://phorge.localhost/herald/transcript/123456/
- After applying this patch, also find that exception in the error log
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15869
Differential Revision: https://we.phorge.it/D25736