Fully modularize Herald field values
Tags None Referenced Files None Subscribers None
Description Fully modularize Herald field values Summary: Ref T8726. This gets rid of all the VALUE_* constants and lets Fields provide arbitrary typeaheads without upstream/JS changes. Test Plan: Used all tokenizers. Used "Another Herald Rule". Grepped for all removed constants. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8726 Differential Revision: https://secure.phabricator.com/D13616
Details
Event Timeline
Changes (58)
R1:715233fb6115 src/applications/differential/herald/DifferentialRevisionRepositoryProjectsHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRepositoryProjectsHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionReviewersHeraldField.phpLoading... src/applications/diffusion/herald/DiffusionPreCommitContentRevisionSubscribersHeraldField.phpLoading... styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand. styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project. Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries. Terms and Conditions (TODO: fix this!) |