Homestyx hydra
Diffusion hydra 713188bf1710

Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete…

Description

Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/project/typeahead/PhabricatorProjectDatasource.php:99]

Closes T15761

Test Plan: Go to a task, enter # and start typing a project tag of a project which has no additional slugs defined.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15761

Differential Revision: https://we.phorge.it/D25556

Details

Provenance
Andre KlapperAuthored on Mar 21 2024, 1:35 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:a69db10c5e15: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser
Branches
Unknown
Tags
Unknown

Event Timeline