Homestyx hydra
Diffusion hydra 6e85b521fe86

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…

Description

Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers

Summary:
Currently, adding subscribers to a draft revision raises a warning that they won't get an email/notification.

This warning has some false positives:

  • it triggers on any subscriber change, including removing subscribers; and
  • it triggers if you're only adding yourself as a subscriber.

Narrow the scope of the warning so it is raised only if you're adding a subscriber other than yourself.

Test Plan:

  • Added a non-self subscriber, got the warning as before.
  • Added self as a subscriber, no warning (previously: warning).
  • Removed a subscriber, no warning (previously: warning).

Differential Revision: https://secure.phabricator.com/D21402

Details

Provenance
epriestleyAuthored on Jul 9 2020, 4:30 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:b21b73b8dd35: Expand Revision transaction API to allow actions to vary more broadly based on…
Branches
Unknown
Tags
Unknown

Event Timeline