Homestyx hydra
Diffusion hydra 6dc20d1e2e71

Fix an issue where storage inlines are fed to InlineAdjustmentEngine

Description

Fix an issue where storage inlines are fed to InlineAdjustmentEngine

Summary:
Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan: Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21239

Details

Provenance
epriestleyAuthored on May 8 2020, 7:49 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:e7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing…
Branches
Unknown
Tags
Unknown

Event Timeline