Diffusion hydra 6a6910835874

Simplify context parsing and add test coverage
6a6910835874
Actions

Description

Simplify context parsing and add test coverage

Summary:

Remove 'missingNew', etc. It's impossible for a diff to popluate these, as far as I can tell (I can't generate such a diff, or find any which generate it).
Add unit tests.

Test Plan: Unit tests, viewed a diff with some missing context.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4393

Details

Provenance

epriestley	Authored on Jan 10 2013, 7:06 PM
sirocyl	Pushed on Oct 16 2024, 5:49 AM

Parents

R1:ebf2435c49fe: Make feed its own application

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (9)

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

DifferentialHunkParser.php

__tests__/

DifferentialHunkParserTestCase.php

data

missing_context.diff

missing_context_2.diff

missing_context_3.diff

render/

DifferentialChangesetRenderer.php

DifferentialChangesetTwoUpRenderer.php

R1:6a6910835874

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/parser/DifferentialHunkParser.php

View Options

src/applications/differential/parser/tests/DifferentialHunkParserTestCase.php

View Options

src/applications/differential/parser/tests/data/missing_context.diff

View Options

src/applications/differential/parser/tests/data/missing_context_2.diff

View Options

src/applications/differential/parser/tests/data/missing_context_3.diff

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Simplify context parsing and add test coverage6a6910835874Actions

Description

Details

Event Timeline

Changes (9)

R1:6a6910835874

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/parser/DifferentialHunkParser.php

src/applications/differential/parser/__tests__/DifferentialHunkParserTestCase.php

src/applications/differential/parser/__tests__/data/missing_context.diff

src/applications/differential/parser/__tests__/data/missing_context_2.diff

src/applications/differential/parser/__tests__/data/missing_context_3.diff

src/applications/differential/render/DifferentialChangesetRenderer.php

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Simplify context parsing and add test coverage
6a6910835874
Actions

src/applications/differential/parser/tests/DifferentialHunkParserTestCase.php

src/applications/differential/parser/tests/data/missing_context.diff

src/applications/differential/parser/tests/data/missing_context_2.diff

src/applications/differential/parser/tests/data/missing_context_3.diff