Homestyx hydra
Diffusion hydra 65e57fe23dd3

Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error

Description

Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error

Summary:
Under PHP 8.1, PhabricatorEditorURIEngine::newForViewer() is throwing a trim(NULL) error when trying to view a diff.
This is because it tries to apply string operations to a user setting which will be null by default.

Fixes T15518

Test Plan:
Unit test added -

arc unit

Or just view a diff. Eg:
https://my.phorge.site/D1234

Reviewers: O1 Blessed Committers, valerio.bozzolan, avivey

Reviewed By: O1 Blessed Committers, valerio.bozzolan, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15518

Differential Revision: https://we.phorge.it/D25324

Details

Provenance
Steve CampbellAuthored on Jul 3 2023, 12:39 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:682fe971a4a9: Do not crop user avatar image in top bar when no Real Name set
Branches
Unknown
Tags
Unknown

Event Timeline