Homestyx hydra
Diffusion hydra 5e2af4b9b5cd

Prepare to support an "Ignore generated files" flag in Owners

Description

Prepare to support an "Ignore generated files" flag in Owners

Summary:
Depends on D19425. Ref T13130. See PHI251. Now that changesets have a durable "generated" attribute, we can let owners packages check it when we're computing which packages are affected by a revision.

There's no way to actualy configure a package to have this behavior yet.

Test Plan:

  • Created a revision affecting a generated file and a non-generated file.
    • When I faked mustMatchUngeneratedPaths() to return true;, saw the non-generated file get no packages owning it.
    • Normally: lots of packages owning it).
  • Created a revision affecting only generated files.
    • When I faked things, saw no Owners actions trigger.
    • Normally: some packages added reviewers or subscribers.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13130

Differential Revision: https://secure.phabricator.com/D19426

Details

Provenance
epriestleyAuthored on May 4 2018, 4:06 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:af295341c863: Classify changesets as "generated" at creation time, in addition to display time
Branches
Unknown
Tags
Unknown

Event Timeline