Homestyx hydra
Diffusion hydra 5ddca7da55e3

Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest…

Description

Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php:33]

Closes T15684

Test Plan: After configuring a custom text field and a dashboard panel to query and listed the latest created tasks, access the panel.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15684

Differential Revision: https://we.phorge.it/D25488

Details

Provenance
Andre KlapperAuthored on Dec 6 2023, 1:29 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:c8a927006067: Use user's preferred font for inline code snippets too
Branches
Unknown
Tags
Unknown

Event Timeline