Homestyx hydra
Diffusion hydra 5a76e8d26232

Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating…

Description

Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating new Diffusion repository

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15301

Test Plan: Applied this change (on top of D25150) and icons rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15301

Differential Revision: https://we.phorge.it/D25151

Details

Provenance
Andre KlapperAuthored on May 1 2023, 4:00 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:6e8852837004: Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All…
Branches
Unknown
Tags
Unknown

Event Timeline