Homestyx hydra
Diffusion hydra 5a0d82df7f86

Fix PHP 8.1 "strlen(null)" exception which blocks rendering creation form pages…

Description

Fix PHP 8.1 "strlen(null)" exception which blocks rendering creation form pages for Legalpad, Macro, Settings

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15309

Test Plan:
Applied this change (on top of D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153, D25154, D25155, D25156, D25158 locally applied)
and the pages /legalpad/edit/, /macro/create/, /settings/builtin/global/
rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15309

Differential Revision: https://we.phorge.it/D25159

Details

Provenance
Andre KlapperAuthored on Apr 30 2023, 1:42 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:d8d45d343ed4: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page
Branches
Unknown
Tags
Unknown

Event Timeline