Homestyx hydra
Diffusion hydra 58f1c83a5ac5

Fix PHP 8.1 "strlen(null)" exception in DivinerFindController

Description

Fix PHP 8.1 "strlen(null)" exception in DivinerFindController

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/diviner/controller/DivinerFindController.php:40]

Closes T15910

Test Plan:
Go to this (or any other Diviner Find URL not passing a type URI parameter): now it works:

http://phorge.localhost/diviner/find/?name=PhutilSafeHTML

Go to this (or any other Diviner Find URL passing a type URI parameter): it still works:

http://phorge.localhost/diviner/find/?name=PhutilSafeHTML&type=class

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15910

Differential Revision: https://we.phorge.it/D25768

Details

Provenance
Andre KlapperAuthored on Aug 11 2024, 10:59 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:2b7c0ec92f6c: Destroy file attachments when file is deleted, or object is deleted
Branches
Unknown
Tags
Unknown

Event Timeline