Homestyx hydra
Diffusion hydra 58b889c5b056

Make the default ApplicationSearch query explicit, not just the first item in…

Description

Make the default ApplicationSearch query explicit, not just the first item in the list

Summary:
Ref T12956. Currently, when you visit /maniphest/ (or any other ApplicationSearch application) we execute the first query in the list by default.

In T12956, I plan to make changes so that personal queries are always first, then global/builtin queries. Without changing the "default query" rule, this will make it harder to have, for example, some custom queries in Differential but still run a global query like "Active" by default. To make this work, you'd have to save a personal copy of the "Active" query, then put it at the top.

This feels a bit cumbersome and this rule is kind of implicit and a little weird anyway. To make this work a little better as we make changes here, add an explicit pinning action, like the one we have in Project ProfileMenus.

You can now explicitly choose a query to make default.

Test Plan:

  • Browsed without pinning anything, saw normal behavior.
  • Pinned queries, viewed /maniphest/, saw a non-initial query selected by default.
  • Pinned a query, deleted it, nothing exploded.

{F5098484}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12956

Differential Revision: https://secure.phabricator.com/D18422

Details

Provenance
epriestleyAuthored on Aug 14 2017, 12:42 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:ec88917dd71e: Remove hover state from labels in action list
Branches
Unknown
Tags
Unknown

Event Timeline