Homestyx hydra
Diffusion hydra 54f131dc4baa

Make "first broadcast" rules for Differential drafts more general

Description

Make "first broadcast" rules for Differential drafts more general

Summary:
See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan:

  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18801

Details

Provenance
epriestleyAuthored on Nov 28 2017, 1:42 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:c7d6fd198cc9: Support "Set X to" as an action in Herald for tokenizer/datasource custom fields
Branches
Unknown
Tags
Unknown

Event Timeline