Homestyx hydra
Diffusion hydra 506f93b4a390

Give policy name rendering explicit "text name", "capability link", and…

Description

Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways

Summary:
Ref T13411. This cleans up policy name rendering. We ultimately render into three contexts:

  • Plain text contexts, like bin/policy show.
  • Transaction contexts, where we're showing a policy change. In these cases, we link some policies (like project policies and custom policies) but the links go directly to the relevant object or a minimal explanation of the change. We don't link policies like "All Users".
  • Capability contexts, where we're describing a capability, like "Can Push" or cases in Applicaitons. In these cases, we link all policies to the full policy explanation flow.

Test Plan:

  • Used bin/policy show to examine the policy of an object with a project policy, no longer saw HTML.
  • Viewed the transaction logs of Applications (ModularTransactions) and Tasks (not ModularTransactions) with policy edits, including project and custom policies.
  • Clicked "Custom Policy" in both logs, got consistent dialogs.
  • Viewed application detail pages, saw all capabities linked to explanatory capability dialogs. The value of having this dialog is that the user can get a full explanation of special rules even if the policy is something mundane like "All Users".

Maniphest Tasks: T13411

Differential Revision: https://secure.phabricator.com/D20804

Details

Provenance
epriestleyAuthored on Sep 12 2019, 10:23 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:c9b0d107f079: Remove unused "icon" parameter from policy name rendering
Branches
Unknown
Tags
Unknown

Event Timeline